Rename SolarHeatingPythonPlugin. Protect with LINK_WITH_PYTHON CMake Flag#11414
Merged
Rename SolarHeatingPythonPlugin. Protect with LINK_WITH_PYTHON CMake Flag#11414
Conversation
mitchute
commented
Feb 9, 2026
| add_simulation_test(IDF_FILE PythonPluginPlantLoopOverrideControl.idf EPW_FILE USA_FL_Orlando.Intl.AP.722050_TMY3.epw) | ||
| add_simulation_test(IDF_FILE PythonPluginPlantOperation_largeOff.idf EPW_FILE USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw) | ||
| add_simulation_test(IDF_FILE PythonPluginReplaceTraditionalManagers_LargeOffice.idf EPW_FILE USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw) | ||
| add_simulation_test(IDF_FILE PythonPluginSolarHeating.idf EPW_FILE USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw ANNUAL_SIMULATION) |
Collaborator
Author
There was a problem hiding this comment.
Move the file to here. Other changes in this section are just sorting the entries.
rraustad
approved these changes
Feb 9, 2026
Collaborator
rraustad
left a comment
There was a problem hiding this comment.
Good change to avoid confusion in CMake file.
Collaborator
Author
|
Thanks @rraustad. It looks like Decent CI got left in an odd state due to all of the connectivity issues on GitHub yesterday. I'm not expecting any issues here. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
The SolarHeatingPythonPlugin file was not named consistently with the other plugin files. This inconsistency likely led to it being placed incorrectly in testfiles/CMakeLists.txt, where it was not protected by the LINK_WITH_PYTHON flag. This update renames the file and relocates it to ensure it is properly covered by this CMake flag.
Description of the purpose of this PR
Pull Request Author
Reviewer